-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add method to revoke attributes closes #45 #46
add method to revoke attributes closes #45 #46
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #46 +/- ##
===========================================
+ Coverage 97.29% 97.40% +0.10%
===========================================
Files 1 1
Lines 74 77 +3
Branches 25 25
===========================================
+ Hits 72 75 +3
Misses 2 2
Continue to review full report at Codecov.
|
any way I can help to merge this PR? @mirceanis could you tell me whom I can contact / who is responsible for this? |
@nikolockenvitz it's only a matter of resources. We didn't have any bandwidth to review this until now. Sorry it's taking this long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Thanks!
Thanks! 😃 |
Created this PR corresponding to issue #45 to revoke attributes.
If further tests are wanted, I can of course add them.