Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method to revoke attributes closes #45 #46

Merged

Conversation

nikolockenvitz
Copy link
Contributor

@nikolockenvitz nikolockenvitz commented Apr 1, 2020

Created this PR corresponding to issue #45 to revoke attributes.

If further tests are wanted, I can of course add them.

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #46 into develop will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    97.29%   97.40%   +0.10%     
===========================================
  Files            1        1              
  Lines           74       77       +3     
  Branches        25       25              
===========================================
+ Hits            72       75       +3     
  Misses           2        2              
Impacted Files Coverage Δ
src/index.js 97.40% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af1efb...f18d42c. Read the comment docs.

@nikolockenvitz
Copy link
Contributor Author

any way I can help to merge this PR?

@mirceanis could you tell me whom I can contact / who is responsible for this?

@mirceanis
Copy link
Contributor

any way I can help to merge this PR?

@mirceanis could you tell me whom I can contact / who is responsible for this?

@nikolockenvitz it's only a matter of resources. We didn't have any bandwidth to review this until now. Sorry it's taking this long.

Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
Thanks!

@mirceanis mirceanis merged commit c9c2915 into uport-project:develop Jun 8, 2020
@nikolockenvitz
Copy link
Contributor Author

Thanks! 😃

mirceanis added a commit that referenced this pull request Dec 17, 2020
[release] 1.2.0

* feat: use latest did-jwt (#41)
* feat: add method to revoke attributes (#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants