This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we can I want to change the rule for |
Zmoki
approved these changes
Jul 12, 2018
And one more thing: "Allow 'x', 'y', 'e', 'i', 'j' variable names" — may be keep only |
e — it's for |
@bautrukevich yep, |
bautrukevich
approved these changes
Jul 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed rules:
==
acc
,res
,req
,e
.'x', 'y', 'e', 'i', 'j'
variable namesmax-nested-callbacks
from 2 to 3max-params
from 3 to 4max-statements
from 10 to 12It is sometimes faster and more obvious to put comments immediately following code
(c) eslint docs++
infor
loopsAdded react rules from https://github.com/uploadcare/webclient-frontend
@Zmoki @bautrukevich
Do you have any suggestions that should be added to this PR? I mean can you remember any rules that you would like to enable, disable or change?