-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] generate the report in the desired path #46
Conversation
@KostiantynPopovych the new feature looks good to me! i especially like the inclusion of a dedicated logging library! but i have to say i'm against including CLI functionality in the core Summed up arguments against it:
besides all that, it was a conscious decision to keep them separate when i initially wrote this so users could import |
jest.config.ts
Outdated
@@ -17,7 +17,7 @@ export default { | |||
clearMocks: true, | |||
|
|||
// Indicates whether the coverage information should be collected while executing the test | |||
collectCoverage: true, | |||
collectCoverage: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not collect coverage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just forgot to rollback it
Hey @kindoflew! Thank you for reviewing! I wrote this after a break, so the initial approach is not perfect, and your points are fair. I rebuilt it, created a standalone entity - |
@KostiantynPopovych -- oohh, i didn't even think of having looking over everything, i wonder if including the file name as part of the for example -- in the main reason i think this is because, as it is, a user would have to remember and know that if they specify a filename it has to have the matching extension or it throws an error. not the biggest deal in the world, but maybe a little bit of a clunky user experience? but |
@kindoflew, hmmm, I thought having an additional option for file name would be too much, but it will definitely be less complicated for us to maintain and probably for users to get used it. So, yeah, I will split the logic into two separate options (the idea of this PR under the hood is to be able to create a report with some specific file name) |
…tions - reportDir and reportFileName
@kindoflew, updated, two options are in place) |
This PR adds the ability to generate a report file in the desired path using CLI and API.