feat(mirror): add an option to specify the base chart version #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Haar <[email protected]>
Signed-off-by: Christopher Haar <[email protected]>
Signed-off-by: Christopher Haar <[email protected]>
sttts
approved these changes
Jul 12, 2024
sttts
reviewed
Jul 12, 2024
| compatibleChartVersion: "1.5.x" | ||
| - image: "xpkg.upbound.io/spaces-artifacts/vcluster:0.15.7" | ||
| - image: "xpkg.upbound.io/spaces-artifacts/vector:0.30.0-distroless-libc" | ||
| - image: "xpkg.upbound.io/spaces-artifacts/xgql:v0.2.0-rc.0.153.g0a1d4ae" |
There was a problem hiding this comment.
how is this list maintained?
There was a problem hiding this comment.
Who updates it and when? Can we get any trigger to update? E.g. from spaces repo with an e2e test.
There was a problem hiding this comment.
yeah we need to do this from spaces repo
There was a problem hiding this comment.
this will be implemented before 1.6
RedbackThomson
pushed a commit
to RedbackThomson/up
that referenced
this pull request
Jul 16, 2024
…d#583) * feat(mirror): add an option to specify the base chart version Signed-off-by: Christopher Haar <[email protected]> * feat(mirror): add an option to specify the base chart version Signed-off-by: Christopher Haar <[email protected]> * feat(mirror): add an option to specify the base chart version Signed-off-by: Christopher Haar <[email protected]> --------- Signed-off-by: Christopher Haar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested