feat(repo): add repo permissions for teams #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs update after sdk is up2date for upbound/up-sdk-go#94 |
turkenh
reviewed
Jun 24, 2024
haarchri
force-pushed
the
feature/repo-permission
branch
from
fdce854
to
3644114
Compare
adamwg
reviewed
Jun 24, 2024
Signed-off-by: Christopher Haar <[email protected]>
haarchri
force-pushed
the
feature/repo-permission
branch
from
3644114
to
b73b6f8
Compare
adamwg
approved these changes
Jun 25, 2024
| return nil | ||
| } | ||
|
|
||
| confirm, err := c.prompter.Prompt(fmt.Sprintf("Are you sure you want to revoke the permission for team %q in repository %q? This cannot be undone [y/n]", c.TeamName, c.RepositoryName), false) |
There was a problem hiding this comment.
"This cannot be undone" is a little strong :-) The permission can always be re-granted, right?
There was a problem hiding this comment.
Yeah same for all other resources ;) let's do this rename in a seperate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
uses upbound/up-sdk-go#94
add repo permission to grant teams permissions
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested