Inject new user agent into all kube rest configs #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedbackThomson
force-pushed
the
new-user-agent
branch
from
2bed7f8
to
be7a1df
Compare
tnthornton
approved these changes
May 9, 2024
RedbackThomson
force-pushed
the
new-user-agent
branch
from
be7a1df
to
7ba46ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
up-cli/<version> (<os>; <arch>)client.Clientcannot be usedExample user agent:
up-cli/v0.30.0-rc.0.15.g18bb4f5.dirty (darwin; arm64)I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Running
up ctx <path>makes multiple calls to spaces, and we can see the requests in the envoy logs:{"downstreamLocalAddress":"10.88.4.252:8443","downstreamRemoteAddress":"10.138.0.37:0","protocol":"HTTP/1.1","startTime":"2024-05-09T23:03:29.593Z","upstreamHost":"10.96.29.179:8443","userAgent":"up-cli/v0.30.0-rc.0.15.g18bb4f5.dirty (darwin; arm64)","upstreamServiceTime":"14","path":"/api/v1","responseCode":200,"requestId":"","downstreamRequestTTLB":0,"bytesSent":192,"responseHeadersBytes":193,"authority":"upbound-gcp-us-west-1.space.mxe.upbound.services","responseFlags":"-","httpMethod":"GET","responseCodeDetails":"via_upstream","upstreamCluster":"mxe-api","upstreamDuration":16,"upstreamRequestTTLB":11,"downstreamResponseTTLB":0,"routeName":"mxe-api","responseTrailersBytes":0,"bytesReceived":0,"xForwardedFor":"10.138.0.37","clientDuration":16