Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #490
The current logic for setting path to
up
in the Kubeconfig AuthInfo exec switches depending on the target release version. If we are on therelease
build, then use"up"
. If we are on thedebug
build, then use the current executable path. This has unfortunate side effects when customers useup
but don't have the CLI inPATH
- the AuthInfo won't ever be able to resolve the exec.This change standardises the mechanism regardless of release target. The AuthInfo will always fall back to the full path of the
up
executable, unless we can guarantee we're running it fromPATH
.I have:
make reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
Running from
PATH
:Running from pwd: