Add up space list command
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlainRoy
reviewed
Apr 3, 2024
RedbackThomson
force-pushed
the
spaces-list
branch
from
02e7b3d
to
297ac03
Compare
sttts
reviewed
Apr 4, 2024
RedbackThomson
force-pushed
the
spaces-list
branch
2 times, most recently
from
d8d2e29
to
eae3dc7
Compare
RedbackThomson
force-pushed
the
spaces-list
branch
from
eae3dc7
to
13f9c6f
Compare
sttts
reviewed
Apr 5, 2024
sttts
reviewed
Apr 5, 2024
sttts
reviewed
Apr 5, 2024
sttts
reviewed
Apr 5, 2024
sttts
reviewed
Apr 5, 2024
| req.AddCookie(&http.Cookie{ | ||
| Name: CookieName, | ||
| Value: rt.session, | ||
| }) |
There was a problem hiding this comment.
We don't support bearer tokens for this? @tnthornton @luxas
There was a problem hiding this comment.
Problem: this stops us from pointing kubectl to it via up ctx.
There was a problem hiding this comment.
Currently we don't, no. @avalanche123 has more context to its limitations.
There was a problem hiding this comment.
Not blocking the PR, preexisting. But we have to work on it.
sttts
reviewed
Apr 7, 2024
sttts
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add a new command
up space listto the CLI to determine what spaces are available to the current authenticated user.Example:
Relies on upbound/up-sdk-go#71
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested