Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-examples job to reusable CI #88

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

turkenf
Copy link
Contributor

@turkenf turkenf commented Mar 22, 2023

Description of your changes

In this PR, the check-examples job has been added to provider-ci.yml which is a reusable CI.

Fixes: #80

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually tested in turkenf/uptest, turkenf/provider-gcp, turkenf/provider-aws and turkenf/provider-azure

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create another failing steps for Configuration packages/platofrm-refs that are using this workflow. We need to incorporate changes from #87 first

@turkenf
Copy link
Contributor Author

turkenf commented Mar 24, 2023

This will create another failing steps for Configuration packages/platofrm-refs that are using this workflow. We need to incorporate changes from #87 first

Hi @ytsarev, these workflows (provider-ci, provider-backport, provider-commands, provider-tag, and provider-updoc) are currently only reused by our official provider repos. So it currently does not affect platform/refs.

Copy link
Contributor

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm. Let's also sync with @ytsarev before merging this.

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Sorry I was too paranoid while fixing uptest failures in platform-refs :D

@turkenf turkenf merged commit ab22586 into upbound:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include check-examples as a step in .github/workflows/provider-ci.yml
3 participants