Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updoc, the tool for publishing official provider docs #79

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Mar 15, 2023

Description of your changes

This PR moves the updoc tool from its previous repository (upbound/official-providers), together with a small fix for reporting errors encountered when uploading the docs to the storage. It also fixes the linter issues and the tests of updoc.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually tested with the official provider releases.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar ulucinar requested a review from turkenf March 15, 2023 14:45
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

Copy link
Contributor

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ulucinar LGTM

@ulucinar ulucinar merged commit 83bd901 into upbound:main Mar 16, 2023
@ulucinar ulucinar deleted the updoc branch March 16, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants