-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tool to measure the performance characteristics of providers #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together @sergenyalcin , it has been invaluable help in the provider Azure performance tests.
@sergenyalcin as we briefly discussed, it would be great to add two new functionalities to the tool: Gather processes from the provider podOn top of measuring resources utilization, we also want to record processes running in the provider pod to make sure there are no Capture state of managed resourcesIn the middle of the experiment, before resources are deleted, we could capture the state of all managed resources with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sergenyalcin, left some comments for you to consider. I think the only blocking comment is the one from @Piotr1215, regarding the metadata naming of the test resources. Thank you very much.
// Data represents a collected data | ||
type Data struct { | ||
Timestamp time.Time | ||
Value float64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We may consider using a string here to support metrics of other types, especially state metrics. But my understanding is that we currently support model.Matrix
as of now, so this should be fine.
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
84d338b
to
ccc844c
Compare
Signed-off-by: Sergen Yalçın <[email protected]>
ccc844c
to
30e2b25
Compare
Description of your changes
With this PR, a tool is added to measure the performance characteristics of providers.
I have:
make reviewable test
to ensure this PR is ready for review.