Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Github workflow dependencies #66

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Bump Github workflow dependencies #66

merged 2 commits into from
Feb 16, 2023

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Feb 8, 2023

Description of your changes

  • Bump fkirc/skip-duplicate-actions Github action to v5.3.0
  • Remove the deprecated set-output command usage
  • Bump actions/cache Github action to v3

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Please see crossplane-contrib/provider-upjet-aws#484

- Bump fkirc/skip-duplicate-actions Github action to v5.3.0
- Remove the deprecated set-output command usage
- Bump actions/cache Github action to v3

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar ulucinar requested a review from turkenf February 8, 2023 08:21
@ulucinar
Copy link
Contributor Author

ulucinar commented Feb 8, 2023

Hi @hasheddan,
Wonder if you know anything about this. Prior to this PR, we have a "Cache Go Dependencies" step, which uses .work/pkg as its target path to be cached. And it gives the following warning:
image

If I interpret this correctly, it complains because at the end of the job run, the target path (to be cached) .work/pkg does not exist. I gave a try to make build.all locally, and this was indeed the case, that directory does not get populated.

Do you know how does the .work/pkg directory gets populated?

Copy link

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulucinar it looks like this PR drops the Go dependency caching -- are you saying you get the path miss when it is not dropped?

@ulucinar
Copy link
Contributor Author

ulucinar commented Feb 9, 2023

@ulucinar it looks like this PR drops the Go dependency caching -- are you saying you get the path miss when it is not dropped?

Yes, correct. That caching was never working because the action cannot find the module cache under .work/pkg. So I just removed that target with this PR. However, we are also building a Go executable (uptest) in this repo and I wonder why the mod cache does not get populated with our common build targets. Do you have any insights? I searched for references of GOPATH in the common build module and cross-checked the official provider repos to see whether we explicitly set GOPATH in our makefiles.

Copy link
Contributor

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar

@ulucinar ulucinar merged commit 810b19e into upbound:main Feb 16, 2023
@ulucinar ulucinar deleted the fix-e1 branch February 16, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants