Add CI, Tag, Backport, Commands workflows and issue templates #62
Conversation
ulucinar
force-pushed
the
ci-fix
branch
5 times, most recently
from
925811e
to
a7c0bc5
Compare
|
@ulucinar can we merge the stuff from #28 in with this PR? I think its time to pull the trigger on that one. I recommend making the repo naming more generic than |
|
Hi @jeanduplessis,
What do you think? |
|
@ulucinar a series of PRs sounds good to me 👍🏻 |
- Move uptest to cmd/uptest - Add version.Version - Add copyright headers Signed-off-by: Alper Rifat Ulucinar <[email protected]>
internal/prepare.go
Outdated
| } | ||
|
|
||
| func generateRFC1123SubdomainCompatibleString() string { | ||
| rand.Seed(time.Now().UnixNano()) | ||
| s := make([]rune, 8) | ||
| for i := range s { | ||
| s[i] = charset[rand.Intn(len(charset))] | ||
| s[i] = charset[rand.Intn(len(charset))] // #nosec G404: no need for crypto/rand here |
There was a problem hiding this comment.
Can // nolint cover this for consistency with the other overrides?
internal/crdschema/crd.go
Outdated
| @@ -232,7 +231,7 @@ func filterNonBreaking(diffMap map[string]*diff.Diff) map[string]*diff.Diff { | |||
| return diffMap | |||
| } | |||
|
|
|||
| func ignoreOptionalNewProperties(sd *diff.SchemaDiff) { | |||
| func ignoreOptionalNewProperties(sd *diff.SchemaDiff) { // nolint:gocyclo | |||
There was a problem hiding this comment.
I highly recommend enabling nolintlint. It requires folks to explain why they're adding a nolint directive, and also catches nolint directives that are ineffective, e.g. because a function that used to be over the cyclomatic complexity level later dropped below it.
There was a problem hiding this comment.
Done. Also broken some high cyclomatic complexity functions.
.golangci.yml
Outdated
| revive: | ||
| # confidence for issues, default is 0.8 | ||
| confidence: 0.8 |
There was a problem hiding this comment.
I suggest removing this block. Doing so causes revive to catch the things that golint used to catch. See crossplane/crossplane@74e387b for more context.
There was a problem hiding this comment.
Thank you @negz, very helpful. When this configuration block is removed, we now have to document, for example, exported APIs. Removed this block, and added some package docs and exported API docs.
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Description of your changes
This PR adds CI, Tag, Backport, Commands workflows and issue templates, and:
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
make reviewableAlso the linter fixes on the regular expressions have been manually validated.