feat(skipDelete): add an option to skip delete at end of test run #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Haar <[email protected]>
|
would be great to cut a new release after - that we can use this |
sergenyalcin
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Thanks @haarchri LGTM!
One note is that, if this reusable workflow is to be used when running Uptest, apart from calling the tool with the skip-delete option, the Cleanup step must also be disabled with an option. Otherwise, this step will delete all existing resources.
|
@sergenyalcin thanks aware of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested