Fix the path from/to which the Go mod cache is populated in e2e test runs #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
fix-gomod-cache
branch
from
1fc24e1
to
bec76e7
Compare
…runs Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
fix-gomod-cache
branch
from
bec76e7
to
15344e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently, we are using
.work/pkgas the path from/to which the Go mod cache is populated in the official providers' e2e tests. This path does not exist and thus the go mods need to be downloaded again during the builds for the e2e tests:This PR proposes to fix that path using the output of the
go.mod.cachedirmake target. I've also verified that the OP reposupbound/provider-{aws,azure/ad,gcp,terraform}all contain that make target.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested against
upbound/provider-aws: