Support for applying manifests in a specified time interval #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
apply-in-interval
branch
from
5bfaa72
to
7512106
Compare
Piotr1215
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
It works great @sergenyalcin , thank you for adding this functionality. I've tested it with the aws provider and intervals of 10 and 45 seconds and it worked as intended. Left one small non-blocking comment.
One more suggestion, it could be nice to indicate timestamps on the resources created so we know that the the --apply-interval flag worked as intended.
Signed-off-by: Sergen Yalçın <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds support for applying manifests in a specified time interval.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested