Remove "version" parameter from the "Provider Publish Service Artifacts" reusable workflow #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts" reusable workflow Signed-off-by: Alper Rifat Ulucinar <[email protected]>
turkenf
approved these changes
Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The current "Publish Service Artifacts" reusable workflow is for power users as it accepts the provider versions to be published as a reusable workflow parameter. I don't think we need this flexibility anymore as it may have some unwanted consequences if not properly used. This PR proposes to remove that parameter.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Successfully validated with: https://github.com/upbound/provider-gcp/actions/runs/5333403079/jobs/9663933596