Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove moved provider-list tool from this repo #122

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Remove moved provider-list tool from this repo #122

merged 1 commit into from
Jun 12, 2023

Conversation

sergenyalcin
Copy link
Member

Description of your changes

Remove moved provider-list tool from this repo

I have:

  • Run make reviewable test to ensure this PR is ready for review.

@sergenyalcin sergenyalcin self-assigned this Jun 12, 2023
ulucinar
ulucinar reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need to update the Makefile and remove provider-list from the Go static packages list.

ulucinar
ulucinar approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin, lgtm.

@sergenyalcin sergenyalcin merged commit 9fa1c12 into upbound:main Jun 12, 2023
@sergenyalcin sergenyalcin deleted the remove-providerlist-tool branch June 12, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar ulucinar approved these changes

Assignees

@sergenyalcin sergenyalcin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergenyalcin @ulucinar