Switch provider families organization from upbound-release-candidates to upbound
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to upbound Signed-off-by: Alper Rifat Ulucinar <[email protected]>
jastang
approved these changes
Jun 9, 2023
| @@ -127,7 +127,7 @@ jobs: | |||
| if [ $num_packages -gt 10 ]; then | |||
| num_packages=10 | |||
| fi | |||
| make -j $num_packages SUBPACKAGES="${{ steps.packages.outputs.target }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound-release-candidates XPKG_REG_ORGS_NO_PROMOTE=xpkg.upbound.io/upbound-release-candidates VERSION=${{ inputs.version }} build.all | |||
| make -j $num_packages SUBPACKAGES="${{ steps.packages.outputs.target }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound XPKG_REG_ORGS_NO_PROMOTE=xpkg.upbound.io/upbound VERSION=${{ inputs.version }} build.all | |||
There was a problem hiding this comment.
do we need to pass XPKG_REG_ORGS and XPKG_REG_ORGS_NO_PROMOTE anymore since xpkg.upbound.io is the default in the provider Makefiles?
There was a problem hiding this comment.
Hi @jastang,
I think it should be okay to remove them. I will give it a try in a follow-up PR.
jeanduplessis
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The reusable workflow currently pushes the built family provider packages under to the
upbound-release-candidatesrepository. We would now like to push them to the respective package repositories under theupboundorganization inxpkg.upbound.io.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested