Accept : or ? in the Makefile export statement for TERRAFORM_PROVIDER_VERSION in native-provider-bump.yml Github workflow #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_VERSION in native-provider-bump.yml Github workflow Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
handle-optional-version
branch
from
da70e02
to
f96c38d
Compare
turkenf
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
@turkenf figured out that we cannot currently open automated native provider version bump PRs for
upbound/provider-azurebecause in that repo's Makefile,TERRAFORM_PROVIDER_VERSIONis optionally exported. This PR proposes a change to also handle the?.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
We manually tested the regular expression change with @turkenf on
upbound/provider-gcp&upbound/provider-azureMakefiles.