-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider family linter #113
Conversation
0c7af1e
to
e902a35
Compare
e902a35
to
36a17b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ulucinar could we move away from ssop
naming in favor of the external naming of provider-family
. It's more descriptive and should cause less confusion going foward.
0fe3953
to
a191e97
Compare
Done. Renamed |
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
…rConfig CRD in package metadata Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
58c83f9
to
18b6423
Compare
…se-candidates` to `upbound` Signed-off-by: Alper Rifat Ulucinar <[email protected]>
18b6423
to
0dfe6e6
Compare
assert that it is not the config package in lint-provider-family. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Description of your changes
This PR adds a new linter,
ssop-linter
, that asserts the following in all the packages in a provider family:domains.activedirectory.gcp.upbound.io
should be packaged in the providerprovider-gcp-activedirectory
. The expected suffix for the provider is the short group name (e.g.,activedirectory
) of the CRD.v1alpha1
API level is supported for the provider metadata)pkg.crossplane.io/provider-family
and the expected value of the config package for the family, e.g.,pkg.crossplane.io/provider-family: provider-family-gcp
for the GCP family.I have:
make reviewable test
to ensure this PR is ready for review.TODO:
How has this code been tested
Tested against the AWS, Azure & GCP provider families with versions
v0.37.0
,v0.34.0
andv0.34.0
, respectively, underxpkg.upbound.io/upbound-release-candidates
.