Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test resource name a bit more complex #112

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

Piotr1215
Copy link

Description of your changes

Currently, the name of the MR under test will be auto generated as test[number] which will became a cloud service name.
Since this is a pretty common pattern, there might be accidental resources override because someone else can create a resource with the same name. This PR extends the test resource name with additional words to make the accidental override more unlikely.

Fixes #

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual local test.

Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Piotr1215 LGTM!

@Piotr1215 Piotr1215 merged commit b251790 into main May 22, 2023
@Piotr1215 Piotr1215 deleted the uniq-test-name branch May 22, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants