This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Build with Go 1.16.1, and remove the whitelist of supported versions #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#122 (comment) Per the above comment thread, most (all?) of our projects now use Go modules, which allow a module to declare the version of Go it targets. It could be that the purpose of this variable is to gate the versions of Go that upbound/build as a library of Makefiles supports, rather than the versions of Go that code built with upbound/build supports. If this is the case, I'd argue that during the the two years I've been using this library we've yet to encounter a new version of Go that has required anything other than a bump to this whitelist and that we never test that the older versions of Go still work. I suspect it would be more productive to pay the price of a newer version of Go breaking the library if and when that becomes an issue than it currently is to bump the var every time a new version of Go is released. Signed-off-by: Nic Cope <[email protected]>
2 tasks
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122
Per #122 (comment), most (all?) of our projects now use Go modules, which allow a module to declare the version of Go it targets.
It could be that the purpose of this variable is to gate the versions of Go that
upbound/buildas a library of Makefiles supports, rather than the versions of Go that code built withupbound/buildsupports. If this is the case, I'd argue that during the the two years I've been using this library we've yet to encounter a new version of Go that has required anything other than a bump to this whitelist and that we never test that the older versions of Go still work. I suspect it would be more productive to pay the price of a newer version of Go breaking the library if and when that becomes an issue than it currently is to bump the var every time a new version of Go is released.Edit: I've now tested this by:
crossplane/crossplanewith this PR, and Go 1.16.1.make img.build && docker run <crosscontainer> go versionfor the Cross container.