-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest with demo.py #226
Pytest with demo.py #226
Conversation
|
If you like, consider introducing Codecov. |
Will we add a minimum coverage requirement? If so then we may need to consider to rewrite the tests. |
Thanks for helping keep improving PixivPy 👍 However, |
The API is relatively simple at present, and there is not a lot of processing logic, so I have not considered doing interface testing before. If you want to write tests, you can consider testing the framework through a JSON-driven interface. For example, read the JSON result of the file through responses, and then assert the results. The advantage of this method is stability, the disadvantage is that it is more troublesome to maintain the JSON files. |
I will try to do them later. |
Closes: #224