Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor audio handling #277

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Refactor audio handling #277

wants to merge 42 commits into from

Commits on Mar 11, 2024

  1. Refactor voice audio handling 

    AudioManager:
* Audio devices get started/stopped on voice connect/disconnect
* Reduce code duplication with Open/TryOpen functions
* Don't store device configs and ids

AudioDevices:
* Rename [Get/Set]ActivePlaybackDevice to [Get/Set]ActivePlaybackDeviceIter
* Declare getters as const and [[nodiscard]]
* Reduce code duplication by using Get[Playback/Capture]DeviceIDFromModel
* Add GetActive[Playback/Capture]
    @ryze312
    ryze312 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b33704b View commit details
    Browse the repository at this point in the history

  2. Apply suggestions 

    - Replace std::move with reference
- Log warning instead of assert on opening/closing devices
- Remove branching in logging + extract into a function
    @ryze312
    ryze312 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cf64646 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. Implement RAII mutex

    @ryze312
    ryze312 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    eb1451a View commit details
    Browse the repository at this point in the history

  2. Implement slice

    @ryze312
    ryze312 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    8e1d681 View commit details
    Browse the repository at this point in the history

  3. Implement data channel

    @ryze312
    ryze312 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    0992139 View commit details
    Browse the repository at this point in the history

  4. Implement thread pool

    @ryze312
    ryze312 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    555a3cd View commit details
    Browse the repository at this point in the history

  5. Fix RemoveSSRC never getting called

    @ryze312
    ryze312 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    dbef57a View commit details
    Browse the repository at this point in the history

  6. Reimplement audio engine

    @ryze312
    ryze312 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    9b550ed View commit details
    Browse the repository at this point in the history

  7. Sync with upstream

    @ryze312
    ryze312 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    b7151f4 View commit details
    Browse the repository at this point in the history

  8. Fix typo: u_int8_t -> uint8_t

    @ryze312
    ryze312 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    39011b6 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Make constructors public for in-place constructor to work

    @ryze312
    ryze312 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    145057f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Apply suggestions

    @ryze312
    ryze312 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f4679b4 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Fix switching devices

    @ryze312
    ryze312 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c59c496 View commit details
    Browse the repository at this point in the history

  2. Use functors for deleters

    @ryze312
    ryze312 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6221b60 View commit details
    Browse the repository at this point in the history

  3. Split VoiceBuffer miniaudio ringbuffer

    @ryze312
    ryze312 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    896714b View commit details
    Browse the repository at this point in the history

  4. Use VoiceClient and DiscordClient signals in VoiceAudio

    @ryze312
    ryze312 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f235bcd View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Wrap ma_log

    @ryze312
    ryze312 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    631eb03 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Remove no longer used stuff in AudioManager

    @ryze312
    ryze312 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    09cff96 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Clean up AudioManager and ifdef conditions, expose VoiceAudio

    @ryze312
    ryze312 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    dffe44e View commit details
    Browse the repository at this point in the history

  2. Make PeakMeter decay itself

    @ryze312
    ryze312 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    486fec9 View commit details
    Browse the repository at this point in the history

  3. Wrap MaEngine

    @ryze312
    ryze312 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    3d89d24 View commit details
    Browse the repository at this point in the history

  4. Implement SystemAudio

    @ryze312
    ryze312 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    2a1150a View commit details
    Browse the repository at this point in the history

  5. Make notification device start on demand

    @ryze312
    ryze312 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    5e0b8f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. More voice sounds

    @ryze312
    ryze312 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    cb44e05 View commit details
    Browse the repository at this point in the history

  2. Why snake case?

    @ryze312
    ryze312 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    030f5da View commit details
    Browse the repository at this point in the history

  3. Add voice sounds

    @ryze312
    ryze312 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    bc4b6d1 View commit details
    Browse the repository at this point in the history

  4. Play connect/disconnect sounds only for the current channel

    @ryze312
    ryze312 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    72e2248 View commit details
    Browse the repository at this point in the history

  5. Don't copy in capture signal

    @ryze312
    ryze312 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    c5fbe39 View commit details
    Browse the repository at this point in the history

  6. i can't type

    @ryze312
    ryze312 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d9373a2 View commit details
    Browse the repository at this point in the history

  7. i can't type 2

    @ryze312
    ryze312 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a762623 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Make ringbuffer more readable and use std::copy_n

    @ryze312
    ryze312 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0558de1 View commit details
    Browse the repository at this point in the history

  2. Fix wrong max bitrate and default EncodingApplication

    @ryze312
    ryze312 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0930bd7 View commit details
    Browse the repository at this point in the history

  3. Implement separate sources for voice

    @ryze312
    ryze312 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    bd45254 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Fix includes, include audio sources only when needed

    @ryze312
    ryze312 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9d5eb73 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Disable LTO on Windows

    @ryze312
    ryze312 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    12e701c View commit details
    Browse the repository at this point in the history

  2. Document separate_sources option in README

    @ryze312
    ryze312 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    98306b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Add missing headers

    @ryze312
    ryze312 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2d96b38 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into audio_refactor

    @ryze312
    ryze312 authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c3cf374 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Update RTP stripping

    @ryze312
    ryze312 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    06fb2a9 View commit details
    Browse the repository at this point in the history

  2. Fix left denoised channel not being written

    @ryze312
    ryze312 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8d4384e View commit details
    Browse the repository at this point in the history

  3. Sync with upstream

    @ryze312
    ryze312 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d6ae366 View commit details
    Browse the repository at this point in the history

  4. Remove duplicate definition of GetPayloadOffset

    @ryze312
    ryze312 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e48e487 View commit details
    Browse the repository at this point in the history