Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scanDirs when nested modules in dirs update #319

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: scanDirs when nested modules in dirs update #319

merged 1 commit into from
Feb 17, 2023

Conversation

ddosakura
Copy link
Contributor

Description

When use nested modules in dirs, handleHotUpdate is not re-scanDirs.

  dirs: [
    // './composables/**', // all nested modules
  ],

Linked Issues

Additional context

@oceangravity
Copy link

+1

@antfu
Copy link
Member

antfu commented Feb 16, 2023

This only solves a very specific case, We should use isMatch from micromatch to check

@antfu
Copy link
Member

antfu commented Feb 16, 2023

For reference: https://github.com/antfu/unplugin-vue-components/blob/9463de0547cdf4f0fd3d1ab79522e3c8ad3adbfc/src/core/utils.ts#L59-L65

@ddosakura ddosakura closed this Feb 17, 2023
@ddosakura ddosakura reopened this Feb 17, 2023
@antfu antfu merged commit 0e3e3d7 into unplugin:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddosakura @oceangravity @antfu