fix: [iOS] [Android] Fix set bitmap stream after delay not update Image - set bitmap URI not update ImageBrush

[ghost]

GitHub Issue (If applicable): closes #5453
closes #7288

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

Changing the stream of a BitmapImage wasn't firing Image Control`s OnSourceChanged event.
It was expected the same behavior like changing UriSource property of BitmapImage.

The same occurs whith ImageBrush when changing the URI of the bitmap.

What is the new behavior?

Now, changing the Stream of a BitmapImage will trigger the OnInvalidated event that make possible to Image Control to update itself, loading the bitmap as it should be.

The OnInvalidated event is also used to make possible Border / ImageBrush track the changes of its ImageSource.

PR Checklist

Please check if your PR fulfills the following requirements:

• Docs have been added/updated which fit documentation template (for bug fixes / features)
• Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
• Validated PR Screenshots Compare Test Run results.
• Contains NO breaking changes
• Associated with an issue (GitHub or internal) and uses the automatic close keywords.
• Commits must be following the Conventional Commits specification.

Other information

[gitpod-io]

[MartinZikmund]

@iury-kc There are some relevant build issues (check the UWP build error messages)

[ghost]

As the Unit Tests are not passing, probably by delay issues, I created UI Tests. Squashed and wainting Azure tests results.

[ghost]

I increased timeout to 10 seconds, however, still having errors waiting controls. And there's another test failing and not exactly related to the commit. Any suggestions? Thanks!!

[carldebilly]

@iury-kc I don't think the problem is timeout related...

• Wasm: https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=1777384&_a=resultQuery
• Android: https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=1777406&_a=resultQ

ImageAssert.AreEqual @ line 420
pixelTolerance: No color tolerance
expected: Before (When_BitmapImage_is_SetSource_After_Delay_Before.png {Width=1024, Height=768}) in {X=10,Y=134,Width=1004,Height=50}
actual  : After (When_BitmapImage_is_SetSource_After_Delay_After.png {Width=1024, Height=768}) in {X=10,Y=134,Width=1004,Height=50}

[ghost]

Tests are giving errors because issues related:

#7328
#8618

Solving that, will allow test pass.

[ghost]

Since #7328 was successfully merged, i`ll go back to this one asap. Thanks @MartinZikmund !!

[agneszitte]

@iury-kc what's left for this PR ;) ?

[ghost]

Sorry @agneszitte-nventive ... didin't see your message.

I was waiting some changes in StorageFile. Then, after going to Uno.Figma I didn't have time to move on with this one.
Rebased now... Let's see!

[agneszitte]

@iury-kc this PR is still a work in progress left aside? (cc @jeromelaban)

[ghost]

Originally it was waiting for some adjusts in StorageFile.cs ..
And then, I couldn't make the tests pass...
I rebased the code to see if the tests were passing now, but they didn't.

Quite sure Im missing something pretty simple. And to be honest, i didn't had time yet to look at it closer, after joinning Figma team. Still Im very curious to understand better this case. If any of you @jeromelaban , @MartinZikmund (since Martin worked in StorageFile.cs) could give me some tips. Thanks!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

iury seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jeromelaban]

These changes overlap the contents of #12234 by @MartinZikmund, where we want to remove subscriptions and events in general (they're more costly than using method overrides). What do you think, @MartinZikmund?

[iurycarlos]

Also, didn't have the chance to test it after #12076 .

[jeromelaban]

The target code has changed significantly, let's review later when this will get prioritized. Thanks!