Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds support for standard protocol activations on wasm #19211

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nickodei
Copy link
Contributor

@nickodei nickodei commented Jan 12, 2025

GitHub Issue (If applicable): closes #11203

PR Type

What kind of change does this PR introduce?

  • Feature
  • Enhancement

What is the current behavior?

Currently, you can only activate a custom protocol on WASM with a web+ prefix, despite browsers supporting some standard protocols docs.

What is the new behavior?

Adds support for some standard protocols that are described in docs or in the issue.

PR Checklist

Please check if your PR fulfills the following requirements:

@nickodei nickodei marked this pull request as draft January 12, 2025 12:43
@github-actions github-actions bot added the platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform label Jan 12, 2025
@nickodei nickodei marked this pull request as ready for review January 12, 2025 12:52
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19211/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19211/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 151736 has failed on Uno.UI - CI.

@nickodei
Copy link
Contributor Author

nickodei commented Jan 15, 2025

On the docs there doesn't seem to be a parameter for the prompt part linke shown in the uno docs:

Uno.Helpers.ProtocolActivation.RegisterCustomScheme(
    "web+myscheme", 
    new System.Uri("http://localhost:55838/"), 
    "Can we handle web+myscheme links?"
);

When I tested it in Edge, there was just the standart-prompt, not the custom text. Should this parameter be removed ?
It seems that this is browser dependent and should be at least documented where it will show the prompt or not.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 152151 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 152152 has failed on Uno.UI - CI.

@nickodei nickodei force-pushed the add-support-for-standard-protocol-activation-wasm branch from a456a4e to 665b15b Compare January 18, 2025 15:13
@unodevops
Copy link
Contributor

⚠️⚠️ The build 152565 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 152566 has failed on Uno.UI - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol activation on Wasm is too restrictive
2 participants