Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol activation on Wasm is too restrictive #11203

Open
Youssef1313 opened this issue Feb 6, 2023 · 4 comments · May be fixed by #19211
Open

Protocol activation on Wasm is too restrictive #11203

Youssef1313 opened this issue Feb 6, 2023 · 4 comments · May be fixed by #19211
Assignees
@nickodei
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request low-hanging-🍒 Categorizes an issue that might be a quick win with meaningful positive impact. platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui)

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Feb 6, 2023 •
edited by MartinZikmund
Loading

Currently, protocol activation on Wasm requires the web+ prefix. According to the docs, the following are also valid:

  • bitcoin
  • ftp
  • ftps
  • geo
  • im
  • irc
  • ircs
  • magnet
  • mailto
  • matrix
  • mms
  • news
  • nntp
  • openpgp4fpr
  • sftp
  • sip
  • sms
  • smsto
  • ssh
  • tel
  • urn
  • webcal
  • wtai
  • xmpp

Notes for contributors

This list of allowed protocols needs to be incorporated into all places where web+ appears in src/Uno.UWP/Helpers/ProtocolActivation.wasm.cs. In addition, please update doc/articles/features/protocol-activation.md with this information.
@Youssef1313 Youssef1313 added kind/enhancement New feature or request platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Feb 6, 2023
@jeromelaban jeromelaban added the project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui) label Feb 6, 2023
@MartinZikmund MartinZikmund added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers low-hanging-🍒 Categorizes an issue that might be a quick win with meaningful positive impact. and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 23, 2023
@nickodei
Copy link
Contributor

nickodei commented Jan 10, 2025 •
edited
Loading

I would be down to implement the change. Will create a PR later.

@morning4coffe-dev
Copy link
Member

Hey @nickodei, thank you for showing your interest in contributing to Uno Platform! I will assign you to this issue and let me know, if you need any help getting started.

@nickodei nickodei linked a pull request Jan 12, 2025 that will close this issue
Open
6 tasks
@nickodei
Copy link
Contributor

Hey, I think that there aren't any tests even for web+ prefixes. Should I add some and the question would be how exactly?

And I also saw that you reviewed #7137. Could you look at a followup refactoring that I also started #19166?

Thank you for offering your support.
I'm new to contributing to uno-platform but would have the time to definitely do more in the next weeks as well.

@morning4coffe-dev
Copy link
Member

Ideally, yes, it would be beneficial to have a test for this. However, I'm not entirely sure if it would work as expected, given that protocol activation needs to be invoked externally to the app. Perhaps some kind of mocking of the request could be a viable approach?

In the meantime, you can refer to this guide on adding Runtime Tests in Uno.UI. Here's an example from one of my recent PRs that you might find helpful.

Thank you for your PR! I'll add it to my to-do list and review it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickodei nickodei

Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request low-hanging-🍒 Categorizes an issue that might be a quick win with meaningful positive impact. platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui)
Projects
Hacktoberfest 2023
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Adds support for standard protocol activations on wasm nickodei/uno
5 participants
@MartinZikmund @jeromelaban @Youssef1313 @nickodei @morning4coffe-dev