Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests away from enzyme to react-testing-library #524

Merged
merged 16 commits into from
Nov 12, 2018
Merged

Migrate tests away from enzyme to react-testing-library #524

merged 16 commits into from
Nov 12, 2018

Conversation

cellog
Copy link
Contributor

@cellog cellog commented Nov 11, 2018

Fixes #467

  • Updates the tests that used enzyme to use react-testing-library
  • removes enzyme and its adapter from package.json
  • fixes some issues with prop-types found when updating tests
  • fixes warnings from invalid html props or missing html props found when updating tests

cellog added 8 commits November 2, 2018 07:15
@cellog
Merge pull request #1 from unlock-protocol/master
4f59740 
update to remote master
@cellog
Merge pull request #2 from unlock-protocol/master
adfe2cc 
merge in master
@cellog
Merge pull request #3 from unlock-protocol/master
66f40fd 
update to master
@cellog
Merge pull request #4 from unlock-protocol/master
ad7bfff 
merge changes
@cellog
Merge pull request #5 from unlock-protocol/master
1fc62d8 
merge in from master
@cellog
fix #476
ece8e34 
 * migrate CreatorLock, Duration, ShowUnlessUserHasKeyToAnyLock,  Web3Provider, pages tests
 * fix invalid markup in EmbedCodeSnippet and Web3Provider
 * fix prop-types mismatches in tests, and missing shape for key and incorrect prop type for locks
@cellog
missed these tests
b5edba0
@cellog
remove enzyme
3edc4fb
julien51
julien51 requested changes Nov 12, 2018
View reviewed changes
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
I think you'll probably need to update jest.setup.js to drop all enzyme references from there.
(One option would be to remove the file but it is likely that we'll need at some point in the future...)

After that we should be all good!

unlock-app/src/__tests__/components/lock/ShowUnlessUserHasKeyToAnyLock.test.js Outdated Show resolved Hide resolved
unlock-app/src/__tests__/components/lock/ShowUnlessUserHasKeyToAnyLock.test.js Outdated Show resolved Hide resolved
unlock-app/src/__tests__/components/lock/ShowUnlessUserHasKeyToAnyLock.test.js Outdated Show resolved Hide resolved
unlock-app/src/__tests__/components/lock/ShowUnlessUserHasKeyToAnyLock.test.js Outdated Show resolved Hide resolved
unlock-app/src/__tests__/components/lock/ShowUnlessUserHasKeyToAnyLock.test.js Outdated Show resolved Hide resolved
unlock-app/src/components/creator/lock/EmbedCodeSnippet.js Show resolved Hide resolved
julien51
julien51 approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@julien51
Copy link
Member

Thanks a lot @cellog !
Merging now!

@julien51 julien51 merged commit 3d02685 into unlock-protocol:master Nov 12, 2018
@cellog cellog deleted the migrate-to-rtl branch November 14, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React testing library vs. enzyme
2 participants
@cellog @julien51