Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next in group default to the latest version 🚀 #1496

Closed
wants to merge 2 commits into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Feb 11, 2019

The dependency next was updated from 7.0.3 to 8.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Find out more about this release.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@cellog
Copy link
Contributor

cellog commented Feb 11, 2019

@cnasc can you verify this works and merge if so, and also check on the paywall split branch? Feel free to to commit this to that branch of it works

@cnasc
Copy link
Contributor

cnasc commented Feb 11, 2019

I think we'll have to hold off on this until vercel/next.js#6240 is settled. When running dev on unlock-app we get:

 ERROR  Failed to compile with 1 errors                              10:11:24 AM

 error  in ./node_modules/next/dist/client/next-dev.js

Module parse failed: Unexpected token (34:6)
You may need an appropriate loader to handle this file type.
|
|
> import('./noop');
| var _window = window,
|     assetPrefix = _window.__NEXT_DATA__.assetPrefix;

 @ multi ./node_modules/next/dist/client/next-dev

@cnasc cnasc added the BLOCKED label Feb 11, 2019
@greenkeeper greenkeeper bot closed this Feb 12, 2019
@greenkeeper greenkeeper bot deleted the greenkeeper/default/next-8.0.0 branch February 12, 2019 15:42
@julien51
Copy link
Member

Yup, that's the one which bit me #1520

@cnasc
Copy link
Contributor

cnasc commented Feb 18, 2019

In the next.js issue, people have workarounds. Not sure how feasible it is for us to try one of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants