Psmf: Ignore last timestamp with old PsmfPlayer libs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bool videoPtsEnd = (s64)psmfPlayerAvcAu.pts >= (s64)totalDurationTimestamp - VIDEO_FRAME_DURATION_TS; | ||
| // If we're out of video data and have no audio, it's over even if the pts isn't there yet. | ||
| return videoPtsEnd || (mediaengine->IsVideoEnd() && mediaengine->IsNoAudioData()); | ||
| if (psmfPlayerLibVersion >= 0x05050010) { |
There was a problem hiding this comment.
Did some testing - this looks incorrect. I added it in hrydgard#6125, but I can't reproduce it now. I think that part may not have been carefully based on tests.
From my current testing, no version of firmware looks at the "last timestamp" value in the file. It always just waits until the end of the file.
I'm going to merge this, since it's basically right, but remove the if in a second commit.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until 5.50
Fix hrydgard#6574