Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow omitting transaction options #483

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

danielroe
Copy link
Member

issue introduced in #250 requires an opts argument to be passed to all drivers

this may be intentional so feel free to close if so!

@danielroe danielroe requested a review from pi0 September 11, 2024 11:06
@danielroe danielroe self-assigned this Sep 11, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 11, 2024

Deploying unstorage with  Cloudflare Pages  Cloudflare Pages

Latest commit: fae841e
Status: ✅  Deploy successful!
Preview URL: https://9405fde4.unstorage.pages.dev
Branch Preview URL: https://fix-optional-opts.unstorage.pages.dev

View logs

getItemRaw?: (key: string, opts: TransactionOptions) => MaybePromise<unknown>;
getItemRaw?: (
key: string,
opts?: TransactionOptions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core sets it when calling drivers.

If in Storage it is not optional i think that is the mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants