Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esbuild): object sourcemap by overriding Object.prototype.toString #399

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix(esbuild): object sourcemap by overriding Object.prototype.toString #399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09a81ce
Fix esbuild object sourcemap by overriding Object.prototype.toString
edemaine Aug 15, 2024
505e6fa
Switch from Object.hasOwn to Object.prototype.hasOwnProperty
edemaine Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/esbuild/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ export function unwrapLoader(
// `load` and `transform` may return a sourcemap without toString and toUrl,
// but esbuild needs them, we fix the two methods
export function fixSourceMap(map: EncodedSourceMap): SourceMap {
if (!('toString' in map)) {
if (!Object.prototype.hasOwnProperty.call(map, 'toString')) {
Object.defineProperty(map, 'toString', {
enumerable: false,
value: function toString() {
return JSON.stringify(this)
},
})
}
if (!('toUrl' in map)) {
if (!Object.prototype.hasOwnProperty.call(map, 'toUrl')) {
Object.defineProperty(map, 'toUrl', {
enumerable: false,
value: function toUrl() {
Expand Down