fix(webpack,rspack): incorrect assumption about the current working directory in webpack and rspack #374
+8
β7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#375
β Type of change
π Description
Build tools can decide to resolve from wherever they want, and it's not guaranteed that the place they resolve from is the user's current working directory.
For example this reproduction of the failure case where in embroider (which uses a
node_modules/.embroider/
directory for the root -- and I imagine svelte apps, too with their.svelte
directory)embroider-build/embroider#1843
Repro here: https://github.com/NullVoxPopuli/embroider-3--unplugin-plugin-loads-app-files
Here is a patched version of unplugin which allows the build to succeed: NullVoxPopuli/embroider-3--unplugin-plugin-loads-app-files#1
π Checklist