Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use webpack loader context to implement addWatchFile #359

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

devongovett
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The current implementation of addWatchFile in webpack uses the compilation.fileDependencies, which does result in the file being watched, but does not associate it with the current module being processed by a loader. As a result, webpack does not trigger recompilation of that module.

This PR fixes this by using the loader context's addDependency function, which both watches the file and adds it as a dependency of the module so it triggers recompilation. A similar API is used for resolvers as well.

Not sure if there is a way to unit test this: I didn't see any tests for watch behavior. However I did test this by npm linking into a project and using the addWatchFile in a webpack project.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@antfu antfu merged commit a3bb13f into unjs:main Feb 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants