Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: drop watchChange hook for esbuild #284

Merged
merged 2 commits into from
Mar 11, 2023
Merged

fix!: drop watchChange hook for esbuild #284

merged 2 commits into from
Mar 11, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Mar 10, 2023

No description provided.

@sxzz sxzz changed the title refactor: remove watchChange hook for esbuild refactor: drop watchChange hook for esbuild Mar 10, 2023
@sxzz sxzz marked this pull request as draft March 10, 2023 13:57
@sxzz sxzz marked this pull request as ready for review March 10, 2023 14:00
@antfu antfu changed the title refactor: drop watchChange hook for esbuild fix!: drop watchChange hook for esbuild Mar 10, 2023
@antfu
Copy link
Member

antfu commented Mar 10, 2023

Reasoning:

esbuild reworked the watch API in v0.17.0: https://github.com/evanw/esbuild/releases/tag/v0.17.0, which makes unplugin not able to emulate watch behavior (namely: evanw/esbuild#2823). As the previous watch feature is also a hacky workaround and not working perfectly, we decided to drop the support for watchChange and make it clear.

@sxzz sxzz requested a review from antfu March 11, 2023 06:13
@antfu antfu merged commit 095849b into unjs:main Mar 11, 2023
lforst
lforst reviewed Apr 3, 2023
View reviewed changes
README.md Show resolved Hide resolved
@bluwy bluwy mentioned this pull request Aug 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst left review comments

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxzz @antfu @lforst