Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add node 18 #185

Merged
merged 3 commits into from
Oct 31, 2022
Merged

ci: add node 18 #185

merged 3 commits into from
Oct 31, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Oct 29, 2022

since nodejs 18 is LTS now.

sxzz added 2 commits October 29, 2022 15:31
since nodejs 18 is LTS now.
@sxzz
Copy link
Member Author

sxzz commented Oct 29, 2022

@antfu Webpack 4 doesn't support node 18. Is it necessary to support Webpack 4 by unplugin now?
The last v4 version is released over one and a half years.

@antfu antfu merged commit 969dacc into unjs:main Oct 31, 2022
@antfu
Copy link
Member

antfu commented Oct 31, 2022

Yes, I think testing with Webpack 4 is necessary as we promise we support it.

@sxzz sxzz deleted the node-lts branch October 31, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants