fix(esbuild): object sourcemap by overriding Object.prototype.toString #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you:
map
from aload
handler, where themap
is produced byJSON.parse
ing a JSON sourcemap (e.g. as returned by esbuild itself),then unplugin ends up outputting a sourcemap of
[object Object]
(encoded in base64) because it overridestoUrl
but nottoString
that's inherited from theObject
prototype.I believe the simple fix in this PR (use
Object.hasOwn
instead ofin
, to avoid checking prototypes) is what is intended, and it fixed the bug I was encountering.Full (but not small) reproduction: https://github.com/DanielXMoore/Civet/tree/main/integration/unplugin-examples/esbuild with
sourceMap: true
added tooptions
inesbuild.js
, and v0.7.22 of@danielx/civet
(I'm about to release a workaround).