Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify withBase jsdocs #266

Merged
merged 1 commit into from
Nov 14, 2024
Merged

docs: clarify withBase jsdocs #266

merged 1 commit into from
Nov 14, 2024

Conversation

pearofducks
Copy link
Contributor

  • The docs for withBase incorrectly referred to a trailing slash instead of the base string
  • Minor typos and grammar fixes

@pearofducks pearofducks changed the title fix(docs): fix miswording in withBase fix(docs): miswording in withBase Nov 14, 2024
@pi0 pi0 changed the title fix(docs): miswording in withBase docs(withBase): clarify Nov 14, 2024
@pi0 pi0 changed the title docs(withBase): clarify docs: clarify withBase jsdocs Nov 14, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 53be020 into unjs:main Nov 14, 2024
1 of 2 checks passed
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (d283cf5) to head (844f3c2).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   95.27%   97.47%   +2.20%     
==========================================
  Files           7        7              
  Lines         867      713     -154     
  Branches      187      237      +50     
==========================================
- Hits          826      695     -131     
+ Misses         41       18      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants