Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(joinURL): allow falsy base #18

Merged
merged 1 commit into from
Mar 9, 2021
Merged

fix(joinURL): allow falsy base #18

merged 1 commit into from
Mar 9, 2021

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe requested a review from pi0 March 5, 2021 19:42
@danielroe danielroe mentioned this pull request Mar 5, 2021
Merged
3 tasks
@pi0 pi0 changed the title fix: support falsy first url part of joinURL fix(joinURL): allow falsy base Mar 6, 2021
@danielroe danielroe changed the title fix(joinURL): allow falsy base fix: ignore falsy base with joinURL Mar 8, 2021
@danielroe danielroe changed the title fix: ignore falsy base with joinURL fix(joinURL): ignore falsy base Mar 8, 2021
@danielroe danielroe changed the title fix(joinURL): ignore falsy base fix(joinURL): allow falsy base Mar 8, 2021
@pi0 pi0 merged commit 73220dd into main Mar 9, 2021
@pi0 pi0 deleted the falsy-join-url branch March 9, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0