Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow exporting/importing matchers #62

Merged
merged 7 commits into from
Aug 17, 2023
Merged

feat: allow exporting/importing matchers #62

merged 7 commits into from
Aug 17, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This allows exporting route matchers directly from the table rather than having to regenerate them.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Aug 17, 2023
@danielroe danielroe requested a review from pi0 August 17, 2023 14:07
@danielroe danielroe self-assigned this Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #62 (61ec54f) into main (09ce6ec) will decrease coverage by 4.64%.
The diff coverage is 65.45%.

❗ Current head 61ec54f differs from pull request most recent head 504d4a7. Consider uploading reports for the commit 504d4a7 to get more accurate results

@@             Coverage Diff             @@
##              main      #62      +/-   ##
===========================================
- Coverage   100.00%   95.36%   -4.64%     
===========================================
  Files            4        4              
  Lines          358      410      +52     
  Branches        72       78       +6     
===========================================
+ Hits           358      391      +33     
- Misses           0       19      +19     
Files Changed Coverage Ξ”
src/matcher.ts 86.61% <61.22%> (-13.39%) ⬇️
src/types.ts 100.00% <100.00%> (ΓΈ)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Blind Trust! πŸ’―)

@pi0 pi0 merged commit 31856ce into main Aug 17, 2023
1 check passed
@pi0 pi0 deleted the feat/export-table branch August 17, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants