-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add http method matching #59
Conversation
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 95.41% 96.15% +0.74%
==========================================
Files 4 4
Lines 414 494 +80
Branches 79 94 +15
==========================================
+ Hits 395 475 +80
Misses 19 19
|
0b7074e
to
8b8474d
Compare
@pi0 Refactored according to your instructions, added benchmarks and more tests. |
d2ae01d
to
9c87773
Compare
@pi0 Just revisiting this PR. I simplified it, rebased and added a description, as well as flagged it as a breaking change due to the |
Put a pending label i need to still benchmark and validate it more. |
Implemented in #107 |
π Linked issue
Resolves #58
β Type of change
π Description
This PR adds a new syntax to allow http method to be matched with radix3.
The current implementation contains a (small) breaking to
staticRoutesMap
, which is now a 2 dimensional array to support fast method matching. A one dimensional approach is possible, but not as robust as the 2 dimensional one #59 (comment).π Checklist