Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: last named segment should be required #123

Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix!: last named segment should be required #123

merged 2 commits into from
Jul 24, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 24, 2024

resolves #119 and related comment in #84 (comment)

I made a twitter survey and it seems most of people expect /blog/* to also match /blog but as another fair point, /blog/:id should not match /blog by default because we are expecting a named parameter.

This PR does a middleground solution to only do edge matching for optional last segments (* and **)

@pi0 pi0 self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (c13c7ee) to head (51f14f2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   99.06%   99.09%   +0.02%     
==========================================
  Files           7        7              
  Lines         321      331      +10     
  Branches      103      103              
==========================================
+ Hits          318      328      +10     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 merged commit e19aa66 into main Jul 24, 2024
2 checks passed
@pi0 pi0 deleted the fix/match-edge branch July 24, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rou3 incorrect matching strategy
1 participant