Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support multiple entries with same route #118

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 9, 2024

Resolves #57

(context: workerd on it as part of h3 refactors to use rou3 as middleware matcher)

Previously we were only supporting one handler for each route (/foo/:bar and /foo/* are the same).

This change changes the store to an array and return type of find to an array.

perf

overhead is < %5

image

@pi0 pi0 self-assigned this Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a293f3b) to head (38669fd).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          299       303    +4     
  Branches        93        93           
=========================================
+ Hits           299       303    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 merged commit 8dd80ed into main Jul 9, 2024
2 checks passed
@pi0 pi0 deleted the feat/multi-data branch July 9, 2024 19:22
@pi0 pi0 mentioned this pull request Jul 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access matched params with matchAll
1 participant