Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: unify apis with method, path order #114

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 8, 2024

Since the introduction of native method support for rou3, it feels much more ergonomic to have method, path in utils order also to make sure users won't miss method or mistakenly use it in reverse order. (this is a breaking change but since rou3 is barely adopted, should go well!)

@pi0 pi0 self-assigned this Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (4aad1cb) to head (470bc31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #114      +/-   ##
===========================================
- Coverage   100.00%   98.90%   -1.10%     
===========================================
  Files            7        7              
  Lines          366      366              
  Branches        85       86       +1     
===========================================
- Hits           366      362       -4     
- Misses           0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 merged commit 170d610 into main Jul 8, 2024
3 of 4 checks passed
@pi0 pi0 deleted the refactor/method-order branch July 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant