-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resolveLockfile
#14
Conversation
3f5e84a
to
afb6ab7
Compare
findWorkspaceRoot
resolveRootPackageJSON
I like the idea of having this building block to write workspace resolution logic but let's give it precise name as it does. |
But, more precisely, it resolves a |
Yeah it is complexer than this to find actual workspace root. I kinda liked the idea to have small utility and combine some heuristics after you renamed from currently if we have a lockfile in subdir, like |
Better way to say: We can probably guess root better if do several find attempts or extract information once and check it more than once (instead of finding nearest pkg+lock combo). Something like |
2b4fc2e
to
39f1f75
Compare
Codecov Report
@@ Coverage Diff @@
## main nuxt/nuxt.js#10939 +/- ##
========================================
- Coverage 96.33% 0 -96.34%
========================================
Files 5 0 -5
Lines 109 0 -109
Branches 26 0 -26
========================================
- Hits 105 0 -105
+ Misses 4 0 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
for implementing nuxt/nuxt#11074 and nitrojs/nitro#149.
Q: We could also have a utility for detecting a version controlled root? Some monorepos don't have a lockfile in their root, e.g. just a
client
andserver
directory, or similar - but I think allowing users to configure likely covers that case.