Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export types from node export condition #407

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

danielroe
Copy link
Member

Looking at resolving type issues in nuxt/nuxt#27702, it seems we don't have types exported from node declarations in ofetch, which means they can't be resolved/imported in some environments.

@danielroe danielroe added the bug Something isn't working label Jun 20, 2024
@danielroe danielroe requested a review from pi0 June 20, 2024 19:21
@danielroe danielroe self-assigned this Jun 20, 2024
@pi0 pi0 changed the title fix: export types from node declaration fix: export types from node export condition Jun 20, 2024
@pi0 pi0 merged commit 8d6d913 into main Jun 20, 2024
4 checks passed
@pi0 pi0 deleted the fix/node-type-exports branch June 20, 2024 19:24
danielroe added a commit to nuxt/nuxt that referenced this pull request Jun 20, 2024
@pi0 pi0 mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants