fix: clear abort timeout after response was received #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniluk4000
force-pushed
the
bugfix/361
branch
2 times, most recently
from
699528c
to
194c886
Compare
|
@pi0 I have tested my fork on my big production project and this have stopped memory groving on my project, it doesn't go as high as 1-2GB and stops on ~400MB. If this could be reviewed & merged we would be so happy :) |
8 tasks
|
Landed in 1.3.4, please let me know if it made any difference @daniluk4000 |
Appreciate it! I have already tested this in production, will update and re-test. Anyone using timeout + asyncContext + SSR should experience heavy memory decrease. |
|
Works like a charm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#361
❓ Type of change
📚 Description
Resolves #361.
Alternative PR to #362. Changes:
📝 Checklist