-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export all types #280
Conversation
β¦om utils to make them available for external usage
I'm really looking forward to this PR being accepted. I've encountered the same issue myself. Directly copying the type definitions does seem a bit strange. |
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 93.46% 92.00% -1.47%
==========================================
Files 5 5
Lines 551 450 -101
Branches 102 102
==========================================
- Hits 515 414 -101
Misses 36 36
|
ResponseType
, ResponseMap
, and MappedType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have rewrote on top of your work to export more type exports.
β Type of change
π Description
I'm building a library around ofetch that needs defines custom fetch functions with the same signature as ofetch, so ideally I would have access to these types to define the function. My current workaround is to copy-paste the types into the library but this doesn't feel quite right.
If there's a reason for these types to not be exported, just close this PR and I will stick to the workaround ππΌ
π Checklist